dawidwys commented on a change in pull request #15331:
URL: https://github.com/apache/flink/pull/15331#discussion_r600527419
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/functions/util/RuntimeUDFContext.java
##########
@@ -44,21 +43,24 @@
private final HashMap<String, Object> initializedBroadcastVars = new
HashMap<>();
Review comment:
very very nit: Could we add a comment it is used only in the
`CollectionExecutor` and can be dropped along with the `DataSet` API. It will
help future readers.
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/utils/ExpressionTestBase.scala
##########
@@ -312,7 +311,8 @@ abstract class ExpressionTestBase {
env.getConfig,
Collections.emptyMap(),
Collections.emptyMap(),
- null)
+ null,
+ new JobID())
Review comment:
hmmm... This is a concerning usage of the `RuntimeUDFContext`. I thought
it should be used only in the `CollectionExecutor`. It is not a concern of this
PR though.
@twalthr @wuchong Do you think we could replace it with something different
here?
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/expressions/utils/ExpressionTestBase.scala
##########
@@ -156,7 +156,8 @@ abstract class ExpressionTestBase {
context._3.getConfig,
new util.HashMap[String, Future[Path]](),
new util.HashMap[String, Accumulator[_, _]](),
- null)
+ null,
+ new JobID())
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
