Github user fpompermaier commented on a diff in the pull request:
https://github.com/apache/flink/pull/1885#discussion_r59715336
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -139,13 +163,10 @@ public void close() throws IOException {
@Override
public boolean reachedEnd() throws IOException {
try {
- if (resultSet.isLast()) {
- close();
- return true;
- }
- return false;
+ return !resultSet.next();
--- End diff --
The problem is that resultSet.isLast() return false when the resultset is
empty and that is the safest solution. Just call it once..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
