KurtYoung commented on a change in pull request #15356:
URL: https://github.com/apache/flink/pull/15356#discussion_r602048462
##########
File path:
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowSerializationSchema.java
##########
@@ -319,7 +323,12 @@ private static RuntimeConverter
createRuntimeConverter(TypeInformation<?> info)
return (csvMapper, container, obj) ->
container.textNode(obj.toString());
} else if (info.equals(Types.LOCAL_DATE_TIME)) {
return (csvMapper, container, obj) ->
-
container.textNode(DATE_TIME_FORMATTER.format((LocalDateTime) obj));
Review comment:
delete useless DATE_TIME_FORMATTER
##########
File path:
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowSerializationSchema.java
##########
@@ -319,7 +323,12 @@ private static RuntimeConverter
createRuntimeConverter(TypeInformation<?> info)
return (csvMapper, container, obj) ->
container.textNode(obj.toString());
} else if (info.equals(Types.LOCAL_DATE_TIME)) {
return (csvMapper, container, obj) ->
-
container.textNode(DATE_TIME_FORMATTER.format((LocalDateTime) obj));
Review comment:
I noticed that this `SQL_TIMESTAMP_FORMAT` is not exactly the same with
`DATE_TIME_FORMATTER`, please double check this won't cause any issue.
##########
File path:
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/RowDataToCsvConverters.java
##########
@@ -268,8 +281,9 @@ private static JsonNode convertTime(int millisecond,
ContainerNode<?> container)
return container.textNode(ISO_LOCAL_TIME.format(time));
}
- private static JsonNode convertTimestamp(TimestampData timestamp,
ContainerNode<?> container) {
- return
container.textNode(DATE_TIME_FORMATTER.format(timestamp.toLocalDateTime()));
Review comment:
delete useless DATE_TIME_FORMATTER
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
