austince commented on a change in pull request #15348:
URL: https://github.com/apache/flink/pull/15348#discussion_r604374553



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/JobGraphJobInformation.java
##########
@@ -50,7 +55,16 @@ public JobGraphJobInformation(JobGraph jobGraph) {
 
     @Override
     public JobInformation.VertexInformation getVertexInformation(JobVertexID 
jobVertexId) {
-        return new JobVertexInformation(jobGraph.findVertexByID(jobVertexId));
+        return new JobVertexInformation(
+                jobGraph.findVertexByID(jobVertexId),
+                vertexParallelismStore
+                        .getParallelismInfo(jobVertexId)
+                        .orElseThrow(

Review comment:
       Ah, I forgot that it is useful to know if the parallelism info has been 
set before accessing fails in the DefaultExecutionGraph: 
https://github.com/austince/flink/blob/bc75fac1757448424d06b5b116733526e0bfe163/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java#L780-L787
   
   We need to fail with a checked `JobException` if that is the case, so I'll 
update the `VertexParallelismStore` to have a `hasParallelismInfo(JobVertexID 
vertexId)` method. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to