[GitHub] [flink] fsk119 commented on pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

Mon, 05 Apr 2021 06:34:09 -0700 


fsk119 commented on pull request #15307:
URL: https://github.com/apache/flink/pull/15307#issuecomment-813395188


   I just come back from the vacation. 
   
   For the comment, I think we can solve by merging the two Calc into one Calc 
with the rule `FlinkCalcMergeRule`.
   
   For the second prolem, I think you should take a look at 
`PushFilterIntoLegacyTableSourceScanRuleTest`. I think the new rule should at 
least pass the tests for `PushFilterIntoTableSourceScanRule`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to