[ 
https://issues.apache.org/jira/browse/FLINK-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247344#comment-15247344
 ] 

ASF GitHub Bot commented on FLINK-3778:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1906#discussion_r60187290
  
    --- Diff: 
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkILoop.scala ---
    @@ -72,7 +72,12 @@ class FlinkILoop(
         
         // create our environment that submits against the cluster (local or 
remote)
         val remoteBenv = new ScalaShellRemoteEnvironment(host, port, this, 
clientConfig)
    -    val remoteSenv = new ScalaShellRemoteStreamEnvironment(host, port, 
this);
    +    val remoteSenv = new ScalaShellRemoteStreamEnvironment(
    +      host,
    +      port,
    +      this,
    +      clientConfig,
    +      getExternalJars(): _*);
    --- End diff --
    
    Wow, never seen `: _*` before :smile:


> ScalaShellRemoteStreamEnvironment cannot be forwarded a user configuration
> --------------------------------------------------------------------------
>
>                 Key: FLINK-3778
>                 URL: https://issues.apache.org/jira/browse/FLINK-3778
>             Project: Flink
>          Issue Type: Improvement
>          Components: Scala Shell
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> The {{ScalaShellRemoteStreamEnvironment}} cannot unlike the 
> {{ScalaShellRemoteEnvironment}} be configured with a user configuration. This 
> effectively prohibits an user to connect against an HA cluster. I think it 
> would be good to be able to specify a user configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to