[GitHub] [flink] leonardBang commented on a change in pull request #15495: [FLINK-21305][table-planner-blink] Fix Cumulative and Hopping window should accumulate late events belonging to the cleaned slice

[GitBox]

leonardBang commented on a change in pull request #15495:
URL: https://github.com/apache/flink/pull/15495#discussion_r612124869



##########
File path: 
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/aggregate/window/processors/SliceSharedWindowAggProcessor.java
##########
@@ -123,6 +124,19 @@ public void merge(@Nullable Long mergeResult, 
Iterable<Long> toBeMerged) throws
         }
     }
 
+    protected long sliceStateMergeTarget(long sliceToMerge) throws Exception {
+        mergeTargetGetter.mergeTarget = null;
+        sliceSharedAssigner.mergeSlices(sliceToMerge, mergeTargetGetter);

Review comment:
       I got the point, but looks this doesn't very clean. Could we  rename 
`SliceMergeTargetGetter`  to `SliceMergeTargetHelper`  because it didn't expose 
`getter` method, and add `setMergeTarget` `getMergeTarget`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org