Github user gyfora commented on a diff in the pull request:
https://github.com/apache/flink/pull/1918#discussion_r60544472
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBValueState.java
---
@@ -64,7 +64,7 @@
* @param stateDesc The state identifier for the state. This contains
name
* and can create a default state value.
*/
- RocksDBValueState(ColumnFamilyHandle columnFamily,
+ public RocksDBValueState(ColumnFamilyHandle columnFamily,
--- End diff --
The reason why I made the state constructors public so if you sublcass the
RocksDBStatebackend you can still manually instantiate them. You wouldnt be
able to call the protected constructor from your package though.
It's no biggie, I can change it if you still think its better as protected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
