[GitHub] [flink] godfreyhe commented on a change in pull request #15559: [FLINK-21627][table-planner-blink] The digest of TableScan & Sink should consider table hints

[GitBox]

godfreyhe commented on a change in pull request #15559:
URL: https://github.com/apache/flink/pull/15559#discussion_r613798035



##########
File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalDataStreamTableScan.scala
##########
@@ -41,12 +40,13 @@ import java.util.function.Supplier
 class FlinkLogicalDataStreamTableScan(
     cluster: RelOptCluster,
     traitSet: RelTraitSet,
+    hints: util.List[RelHint],
     table: RelOptTable)
-  extends TableScan(cluster, traitSet, Collections.emptyList[RelHint](), table)
+  extends TableScan(cluster, traitSet, hints, table)

Review comment:
       yes, it's better for us to consider all the TableScans in this pr, 
although we can not add hints for DataStream table.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org