Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1903#issuecomment-213573556
Thanks for the quick update @fpompermaier! The changes look mostly good.
What is missing are tests that verify that `DataSourceTask` and
`GenericDataSourceBase` correctly call the new methods as part of their IF life
cycle. Can you extend `GenericDataSourceBaseTest` and `DataSourceTask` and add
tests to validate that the methods are called (maybe by using a mocked
`RichInputFormat`)? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
