curcur commented on pull request #15636: URL: https://github.com/apache/flink/pull/15636#issuecomment-821800955
Hey, @rkhachatryan , I've done with the review. 1. Overall the logic is pretty clear, please refer to a few of my comments. 2. The exactly-once end2end test is too simple, it only includes a test for insert, at least add one failure recovery test? 3. Address the connection closing issue found yesterday on top of "https://github.com/apache/flink/pull/15627"; 4. I think this PR might also fix the problem a user reported when connecting to Oracle, please double-check (FLINK-22311) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
