LadyForest commented on a change in pull request #13011:
URL: https://github.com/apache/flink/pull/13011#discussion_r615561391
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -1293,6 +1328,121 @@ private TableResult buildShowResult(String columnName,
String[] objects) {
Arrays.stream(objects).map((c) -> new String[]
{c}).toArray(String[][]::new));
}
+ private String buildShowCreateTableRow(
+ ResolvedCatalogBaseTable<?> table,
+ ObjectIdentifier sqlIdentifier,
+ boolean isTemporary) {
+ CatalogBaseTable.TableKind kind = table.getTableKind();
+ if (kind == CatalogBaseTable.TableKind.VIEW) {
+ throw new TableException(
+ String.format(
+ "SHOW CREATE TABLE does not support showing CREATE
VIEW statement with identifier %s.",
+ sqlIdentifier.asSerializableString()));
+ }
+ StringBuilder sb =
+ new StringBuilder(
+ String.format(
+ "CREATE %sTABLE %s (\n",
+ isTemporary ? "TEMPORARY " : "",
+ sqlIdentifier.asSerializableString()));
+ ResolvedSchema schema = table.getResolvedSchema();
+ // append columns
+ sb.append(
+ schema.getColumns().stream()
+ .map(column -> String.format("%s%s", printIndent,
getColumnString(column)))
+ .collect(Collectors.joining(",\n")));
+ // append watermark spec
+ if (!schema.getWatermarkSpecs().isEmpty()) {
+ sb.append(",\n");
+ sb.append(
+ schema.getWatermarkSpecs().stream()
+ .map(
+ watermarkSpec ->
+ String.format(
+ "%sWATERMARK FOR %s AS %s",
+ printIndent,
+ String.join(
+ ".",
Review comment:
> We don't need this `.`, right?
Hi Jark, you're right. Btw, I found this impl in
`WatermarkSpec#asSummaryString` and took a reference at that time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
