[ 
https://issues.apache.org/jira/browse/FLINK-22369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325553#comment-17325553
 ] 

Yun Tang edited comment on FLINK-22369 at 4/20/21, 7:39 AM:
------------------------------------------------------------

[~sjwiesman] , I wonder do we really need this feature to ensure users of the 
legacy {{RocksDBStateBackend}} see consistent logging since we need to 
introduce other more code and test to just make such a small feature work. If 
we could just remove such small feature, things could be much simpler.


was (Author: yunta):
[~sjwiesman] , I already have local PR to fix this. However, I wonder do we 
really need this feature to ensure users of the legacy {{RocksDBStateBackend}} 
see consistent logging since we need to introduce other more code and test to 
just make such a small feature work. If we could just remove such small 
feature, things could be much simpler.

> RocksDB state backend might occur ClassNotFoundException when deserializing 
> on TM side
> --------------------------------------------------------------------------------------
>
>                 Key: FLINK-22369
>                 URL: https://issues.apache.org/jira/browse/FLINK-22369
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.13.0
>            Reporter: Yun Tang
>            Priority: Blocker
>             Fix For: 1.13.0
>
>         Attachments: image-2021-04-20-15-18-49-706.png
>
>
> FLINK-19467 introduced new {{EmbeddedRocksDBStateBackend}} and added new 
> interface 
> {{[EmbeddedRocksDBStateBackend#setLogger|https://github.com/apache/flink/blob/24031e55e4cf35a5818db2e927e65b290a9b2aed/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/EmbeddedRocksDBStateBackend.java#L287]}}
>  to ensures users of the legacy {{RocksDBStateBackend}} see consistent 
> logging.
> However, this change introduce another non transient 
> {{[logger|https://github.com/apache/flink/blob/24031e55e4cf35a5818db2e927e65b290a9b2aed/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/EmbeddedRocksDBStateBackend.java#L115]}}
>  and it would be deserialized on TM side first. If the client has different 
> log4j implementation from TM side, we might meet ClassNotFoundException:
>  !image-2021-04-20-15-18-49-706.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to