SteNicholas commented on pull request #15020:
URL: https://github.com/apache/flink/pull/15020#issuecomment-823699494


   @XComp , thanks for your detailed comments for the refactoring.  Based on 
your finding, I thought that:
   
   1. `PythonBasedPackagedProgramRetriever` is indeed a 
`JarFilePackagedProgramRetriever` with a specific `jarFile` and `jobClassName`, 
which could be removed and pass in these specific parameter values in 
`JarFilePackagedProgramRetriever`.
   2. `PackagedProgramRetriever` implementation could be similified by 
introducing interface `EntryClassInformationProvider` providing `getJarFile()` 
and `getJobClassName()` as methods.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to