tillrohrmann commented on a change in pull request #14012:
URL: https://github.com/apache/flink/pull/14012#discussion_r619364433
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -25,7 +25,7 @@ MINIKUBE_START_RETRIES=3
MINIKUBE_START_BACKOFF=5
RESULT_HASH="e682ec6622b5e83f2eb614617d5ab2cf"
MINIKUBE_VERSION="v1.8.2"
-MINIKUBE_PATH="/usr/local/bin/minikube-$MINIKUBE_VERSION"
+MINIKUBE_PATH=$([ "${OS_TYPE}" != "linux" ] && echo "minikube" || echo
"/usr/local/bin/minikube-$MINIKUBE_VERSION")
Review comment:
Why is this change necessary @wangyang0918?
##########
File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh
##########
@@ -178,21 +180,9 @@ function cleanup {
stop_kubernetes
}
-function setConsoleLogging {
- cat >> $FLINK_DIR/conf/log4j.properties <<END
-rootLogger.appenderRef.console.ref = ConsoleAppender
-
-# Log all infos to the console
-appender.console.name = ConsoleAppender
-appender.console.type = CONSOLE
-appender.console.layout.type = PatternLayout
-appender.console.layout.pattern = %d{yyyy-MM-dd HH:mm:ss,SSS} %-5p [%t] %-60c
%x - %m%n
-END
-}
Review comment:
Why don't we need this logging anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
