godfreyhe opened a new pull request #15759: URL: https://github.com/apache/flink/pull/15759
## What is the purpose of the change *The windowStart in WindowAttachedWindowingStrategy may be -1 when two phase is enabled for distinct agg (see [TwoStageOptimizedWindowAggregateRule.java#L143](https://github.com/apache/flink/blob/a3363b91b144edfbae5ab114984ded622d3f8fbc/flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/TwoStageOptimizedWindowAggregateRule.java#L143) ). While there is a validation (windowStart >= 0) in the constructor of WindowAttachedWindowingStrategy. this pr aims to fix it.* ## Brief change log - *Remove the validation for windowStart in the constructor of WindowAttachedWindowingStrategy * - *Add some plan test and UT* - *Fix the typo of WindowAggregateJsonITCase, that is the parameter should be ONE_PHASE and TWO_PHASE not ONE_PHASE and ONE_PHASE* ## Verifying this change This change added tests and can be verified as follows: - *Extended WindowAggregateJsonITCase and WindowAggregateJsonPlanTest to verify the change* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
