[ https://issues.apache.org/jira/browse/FLINK-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268383#comment-15268383 ]
ASF GitHub Bot commented on FLINK-3650: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1856#discussion_r61853639 --- Diff: flink-scala/src/test/scala/org/apache/flink/api/operator/MaxByOperatorTest.scala --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.api.operator + +import org.apache.flink.api.common.InvalidProgramException +import org.apache.flink.api.common.typeinfo.BasicTypeInfo +import org.apache.flink.api.java.tuple.{Tuple, Tuple5} +import org.apache.flink.api.java.typeutils.TupleTypeInfo +import org.apache.flink.api.scala._ +import org.junit.Test +import org.junit.Assert; + +class MaxByOperatorTest { + private val emptyTupleData = List[Tuple5[Integer, Long, String, Long, Integer]]() + private val customTypeData = List[CustomType](new CustomType()) + private val tupleTypeInfo: TupleTypeInfo[Tuple5[Integer, Long, String, Long, Integer]] = --- End diff -- A Scala tuple is `scala.Tuple2[Int, String]`, for example. But not `o.a.f.api.java.tuple.Tuple2`. > Add maxBy/minBy to Scala DataSet API > ------------------------------------ > > Key: FLINK-3650 > URL: https://issues.apache.org/jira/browse/FLINK-3650 > Project: Flink > Issue Type: Improvement > Components: Java API, Scala API > Affects Versions: 1.1.0 > Reporter: Till Rohrmann > Assignee: ramkrishna.s.vasudevan > > The stable Java DataSet API contains the API calls {{maxBy}} and {{minBy}}. > These methods are not supported by the Scala DataSet API. These methods > should be added in order to have a consistent API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)