Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r62832955
--- Diff:
flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
@@ -157,14 +216,25 @@ public boolean reachedEnd() throws IOException {
* @throws java.io.IOException
*/
@Override
- public OUT nextRecord(OUT tuple) throws IOException {
+ public Row nextRecord(Row row) throws IOException {
try {
- resultSet.next();
- if (columnTypes == null) {
- extractTypes(tuple);
+ hasNext = resultSet.next();
+ if (!hasNext) {
+ return null;
+ }
+ try {
+ //This throws a NPE when the TypeInfo is not
passed to the InputFormat,
+ //i.e. KryoSerializer used to generate the
passed row
+ row.productArity();
+ } catch(NullPointerException npe) {
+ ResultSetMetaData resultSetMetaData =
resultSet.getMetaData();
+ row = new
Row(resultSetMetaData.getColumnCount());
+ LOG.warn("TypeInfo not provided to the
InputFormat. Row cannot be reused.");
}
- addValue(tuple);
- return tuple;
+ for (int pos = 0; pos < row.productArity(); pos++) {
+ row.setField(pos, resultSet.getObject(pos + 1));
+ }
+ return row;
} catch (SQLException se) {
close();
--- End diff --
Let the data source task call `close()`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
