dianfu commented on a change in pull request #15813: URL: https://github.com/apache/flink/pull/15813#discussion_r629295662
########## File path: flink-python/src/main/java/org/apache/flink/python/util/TarGzUtils.java ########## @@ -0,0 +1,69 @@ +package org.apache.flink.python.util; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.util.IOUtils; + +import org.apache.commons.compress.archivers.ArchiveInputStream; +import org.apache.commons.compress.archivers.tar.TarArchiveEntry; +import org.apache.commons.compress.archivers.tar.TarArchiveInputStream; +import org.apache.commons.compress.compressors.gzip.GzipCompressorInputStream; + +import java.io.BufferedInputStream; +import java.io.ByteArrayInputStream; +import java.io.File; +import java.io.FileOutputStream; +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.nio.file.Files; +import java.nio.file.Paths; + +/** Utils used to extract tar.gz files and try to restore the origin permissions of files. */ +@Internal +public class TarGzUtils { Review comment: Since there is already DecompressUtils file and so I'm in favor of moving the code there. Otherwise we have three files for decompression: DecompressUtils, TarGzUtils, ZipUtils. It's a little confusing for users. Since most of the code are newly added and so I think it will be all right for code review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org