Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1981#issuecomment-219172614
Hi @dawidwys,
the runtime code, rule, API methods, and the tests look very good. :-)
PR #1958 should be ready to be merged (waiting for @twalthr to give his
OK). I think you can rebase your code on top of #1958.
One last comment with respect to style fixes. Unfortunately, we do not have
a strict code style in place that is automatically enforced and contributors
follow sometimes different styles. We try to keep style changes in PRs to a
minimum. Some changes make absolutely sense, but other changes might be
reverted by the next person going over the file. Also style changes can
distract from important changes. There is no hard rule for what to change, but
a good rule of thumb is to leave code as it is if in doubt.
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
