AHeise commented on a change in pull request #15905:
URL: https://github.com/apache/flink/pull/15905#discussion_r633698769



##########
File path: flink-python/pyflink/table/descriptors.py
##########
@@ -33,7 +33,6 @@
     'FileSystem',
     'Kafka',
     'Elasticsearch',
-    'HBase',

Review comment:
       Does this mean, you cannot use HBase from Python anymore? Why is it 
different than the other connectors?

##########
File path: 
flink-connectors/flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/util/HBaseTestBase.java
##########
@@ -131,7 +120,7 @@ private static void createHBaseTable1() throws IOException {
                         Timestamp.valueOf("2019-08-18 19:00:00"),
                         Date.valueOf("2019-08-18"),
                         Time.valueOf("19:00:00"),
-                        new BigDecimal(12345678.0001)));
+                        new BigDecimal("12345678.0001")));

Review comment:
       These changes should probably go to a different commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to