tillrohrmann commented on a change in pull request #15812:
URL: https://github.com/apache/flink/pull/15812#discussion_r634141748
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolInteractionsTest.java
##########
@@ -137,32 +128,22 @@ public void testSlotAllocationTimeout() throws Exception {
assertTrue(ExceptionUtils.stripExecutionException(e)
instanceof TimeoutException);
}
- // wait until we have timed out the slot request
- slotRequestTimeoutFuture.get();
-
- assertEquals(0L, pool.getNumberOfPendingRequests());
+ testMainThreadExecutor.execute(
+ () ->
assertTrue(pool.getAllocatedSlotsInformation().isEmpty()));
}
}
- /** Tests that extra slots are kept by the {@link SlotPoolImpl}. */
+ /** Tests that extra slots are kept by the {@link SlotPool}. */
@Test
public void testExtraSlotsAreKept() throws Exception {
Review comment:
Please also check whether this behavior is not already covered by a
different test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
