[ 
https://issues.apache.org/jira/browse/FLINK-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286742#comment-15286742
 ] 

Maximilian Michels commented on FLINK-3909:
-------------------------------------------

Failing tests are not supposed to fail the entire build in the 
{{integration-test}} phase:

{quote}
The Failsafe Plugin is used during the integration-test and verify phases of 
the build lifecycle to execute the integration tests of an application. The 
Failsafe Plugin will not fail the build during the integration-test phase, thus 
enabling the post-integration-test phase to execute.
{quote}
https://maven.apache.org/surefire/maven-failsafe-plugin/

The verify phase also runs afterwards but doesn't receive the failed tests from 
the previous phase. It appears the test failures are read from the 
{{failsafe-reports}} file in the verify phase.

I verified on my machine that Exceptions thrown in the integration-tests phase 
let maven fail the build on {{mvn verify}}.
{noformat}
[INFO] --- maven-failsafe-plugin:2.18.1:verify (default) @ flink-tests_2.10 ---
[INFO] Failsafe report directory: 
/Users/max/Dev/flink/flink-tests/target/failsafe-reports
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.18.1:verify (default) on 
project flink-tests_2.10: There are test failures.
{noformat}

On Travis, all we get is 
{noformat}
[INFO] --- maven-failsafe-plugin:2.18.1:verify (default) @ flink-tests_2.10 ---
[INFO] Failsafe report directory: 
/home/travis/build/apache/flink/flink-tests/target/failsafe-reports
{noformat}

The {{executions}} are set up correctly in the parent pom. I'll try to 
reproduce the error on Travis with activated debug logging.

> Maven Failsafe plugin may report SUCCESS on failed tests
> --------------------------------------------------------
>
>                 Key: FLINK-3909
>                 URL: https://issues.apache.org/jira/browse/FLINK-3909
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.1.0
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 1.1.0
>
>
> The following build completed successfully on Travis but there are actually 
> test failures: https://travis-ci.org/apache/flink/jobs/129943398#L5402



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to