Airblader commented on a change in pull request #16006:
URL: https://github.com/apache/flink/pull/16006#discussion_r639668340
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java
##########
@@ -276,6 +280,10 @@ private SqlToOperationConverter(FlinkPlannerImpl
flinkPlanner, CatalogManager ca
converter.convertBeginStatementSet((SqlBeginStatementSet)
validated));
} else if (validated instanceof SqlEndStatementSet) {
return
Optional.of(converter.convertEndStatementSet((SqlEndStatementSet) validated));
+ } else if (validated instanceof SqlSet) {
Review comment:
The behavior to return `empty()` seems consistent/sane to me given the
contract. If you do end up trying to execute it, you'd get
`TableEnvironmentImpl#UNSUPPORTED_QUERY_IN_EXECUTE_SQL_MSG` which is pretty
elaborate (and nothing about this changed here anyway – you couldn't run SET
through `TableEnvironment#execute*` and you can't now).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
