godfreyhe commented on a change in pull request #14916:
URL: https://github.com/apache/flink/pull/14916#discussion_r640270303



##########
File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/LogicalCorrelateToJoinFromTemporalTableFunctionRule.scala
##########
@@ -153,9 +153,8 @@ class LogicalCorrelateToJoinFromTemporalTableFunctionRule
     */
   private def getRelOptSchema(relNode: RelNode): RelOptSchema = relNode match {

Review comment:
       we should avoid to get `RelOptSchema` from RelNode, another approach is 
we can add a method to get `FlinkRelBuilder` directly in `FlinkOptimizeContext`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to