leonardBang commented on a change in pull request #15821:
URL: https://github.com/apache/flink/pull/15821#discussion_r631594656
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala
##########
@@ -754,6 +754,18 @@ class ExprCodeGenerator(ctx: CodeGeneratorContext,
nullableInput: Boolean)
case MAP_VALUE_CONSTRUCTOR =>
generateMap(ctx, resultType, operands)
+ case GREATEST =>
+ operands.foreach { operand =>
+ requireComparable(operand)
+ }
+ generateGreatestLeast(resultType, operands)
+
+ case LEAST =>
+ operands.foreach { operand =>
+ requireComparable(operand)
+ }
+ generateGreatestLeast(resultType, operands, greatest = false)
+
Review comment:
we could only support in built-in functions in SQL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
