Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1941#discussion_r63703304
--- Diff:
flink-batch-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java
---
@@ -102,58 +116,62 @@ public void testJDBCOutputFormat() throws
IOException, InstantiationException, I
.finish();
jdbcOutputFormat.open(0, 1);
- jdbcInputFormat = JDBCInputFormat.buildJDBCInputFormat()
- .setDrivername(DRIVER_CLASS)
- .setDBUrl(DB_URL)
- .setQuery(SELECT_ALL_BOOKS)
-
.setResultSetType(ResultSet.TYPE_SCROLL_INSENSITIVE)
- .finish();
- jdbcInputFormat.openInputFormat();
- jdbcInputFormat.open(null);
-
- Row row = new Row(tuple5.getArity());
- while (!jdbcInputFormat.reachedEnd()) {
- if (jdbcInputFormat.nextRecord(row) != null) {
+ try (
+ Connection dbConn =
DriverManager.getConnection(JDBCTestBase.DB_URL);
--- End diff --
Can't you simply use `JDBCTestBase.testData` instead of reading it from the
DB?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
