dianfu commented on a change in pull request #15877:
URL: https://github.com/apache/flink/pull/15877#discussion_r642277807
##########
File path: flink-python/pyflink/fn_execution/operation_utils.py
##########
@@ -44,6 +45,34 @@
_constant_num = 0
+def wrap_table_function_result(it):
Review comment:
```suggestion
def normalize_table_function_result(it):
```
##########
File path: flink-python/pyflink/fn_execution/beam/beam_coder_impl_slow.py
##########
@@ -15,53 +15,118 @@
# See the License for the specific language governing permissions and
# limitations under the License.
################################################################################
-
import datetime
import decimal
-import cloudpickle
import struct
-from typing import Any, Tuple
-from typing import List
+from abc import ABC, abstractmethod
+from typing import Any, List
+import cloudpickle
import pyarrow as pa
from apache_beam.coders.coder_impl import StreamCoderImpl, create_InputStream,
create_OutputStream
-from pyflink.fn_execution.flink_fn_execution_pb2 import CoderParam
-from pyflink.fn_execution.ResettableIO import ResettableIO
from pyflink.common import Row, RowKind
from pyflink.datastream.window import TimeWindow, CountWindow
+from pyflink.fn_execution.ResettableIO import ResettableIO
+from pyflink.fn_execution.flink_fn_execution_pb2 import CoderParam
from pyflink.table.utils import pandas_to_arrow, arrow_to_pandas
ROW_KIND_BIT_SIZE = 2
-class TimeWindowCoderImpl(StreamCoderImpl):
+class BaseCoderImpl(ABC, StreamCoderImpl):
Review comment:
```suggestion
class LengthPrefixBaseCoderImpl(ABC, StreamCoderImpl):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
