[
https://issues.apache.org/jira/browse/FLINK-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290796#comment-15290796
]
ASF GitHub Bot commented on FLINK-3836:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1966#issuecomment-220275206
I like the addition. Two things, however, that I am not sure about:
1. The `Histogram` uses a `LongHistogram` internally, which results in a
lot of wrapping and converting. Each accumulator report (each heartbeat) needs
to do the conversion. I think the Histogram should rather hold the proper (int,
int) map directly.
2. I am skeptical about failing hard in the Histogram on an integer
overflow. These kind of hard failures in utility types are always tricky. A
program causing an overflow will result in a non-recoverable failure (it will
always overflow again). For streaming programs, that is not a nice property. I
would actually rather try to deprecate the int histogram (let it overflow) and
encourage to replace it over time completely with the long histogram.
> Change Histogram to enable Long counters
> ----------------------------------------
>
> Key: FLINK-3836
> URL: https://issues.apache.org/jira/browse/FLINK-3836
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.2
> Reporter: Maximilian Bode
> Assignee: Maximilian Bode
> Priority: Minor
>
> Change
> flink/flink-core/src/main/java/org/apache/flink/api/common/accumulators/Histogram.java
> to enable Long counts instead of Integer. In particular, change the TreeMap
> to be <Integer, Long>.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
