hameizi commented on a change in pull request #15638:
URL: https://github.com/apache/flink/pull/15638#discussion_r645235326



##########
File path: 
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogTest.java
##########
@@ -120,4 +120,23 @@ public void testRetrieveFlinkProperties() throws Exception 
{
         assertEquals(
                 hiveTable.getOptions().get("flink.url"), 
"jdbc:clickhouse://host:port/testUrl2");
     }
+
+    @Test
+    public void testGetNoSchemaGenericTable() throws Exception {
+        ObjectPath hiveObjectPath =
+                new ObjectPath(HiveCatalog.DEFAULT_DB, 
"testGetNoSchemaGenericTable");
+
+        Map<String, String> properties =
+                new HashMap<>(new 
FileSystem().path("/test_path").toProperties());

Review comment:
       Because in the lastest code, the table that not have properties 
'connector' will be define as a hive table but not a GenericTable. And the hive 
table can be drop when it is no schema.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to