alpinegizmo commented on a change in pull request #16088:
URL: https://github.com/apache/flink/pull/16088#discussion_r646434410



##########
File path: 
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/rank/window/WindowRankOperatorBuilder.java
##########
@@ -125,7 +125,7 @@ public WindowRankOperatorBuilder windowEndIndex(int 
windowEndIndex) {
                 rankStart > 0,
                 String.format("Illegal rank start %s, it should be positive!", 
rankStart));
         checkArgument(
-                rankEnd > 1,
+                rankEnd >= 1,
                 String.format("Illegal rank end %s, it should be bigger than 
1!", rankEnd));

Review comment:
       ```suggestion
                   String.format("Illegal rank end %s, it should be at least 
1!", rankEnd));
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to