[ 
https://issues.apache.org/jira/browse/FLINK-22963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361341#comment-17361341
 ] 

JasonLee commented on FLINK-22963:
----------------------------------

Hi Xintong


Thank you for your confirmation and changes to the issue.


When I checked the source code in multiple versions, I found that the 
description of TASK_HEAP_MEMORY in the 
org.apache.flink.configuration.TaskManagerOptions class is also wrong. For 
example, Flink 1.10. 


So in addition to the version you specified, do other affected versions need to 
be repaired? so it can Modify the source code and documentation. If possible, I 
can fix this issue for the community.


Best,
Jason
JasonLee
jasonlee1...@163.com
签名由网易邮箱大师定制


在2021年06月11日 09:53,Xintong Song (Jira)<j...@apache.org> 写道:

[ 
https://issues.apache.org/jira/browse/FLINK-22963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xintong Song 更新了 FLINK-22963:
-----------------------------
影响版本:     (原值: 1.13.0)
(原值: 1.12.0)
(原值: 1.10.0)
1.14.0
1.13.1
1.12.4

The description of taskmanager.memory.task.heap.size in the official document 
is incorrect
------------------------------------------------------------------------------------------

关键字: FLINK-22963
URL: https://issues.apache.org/jira/browse/FLINK-22963
项目: Flink
问题类型: 故障
模块: Documentation
影响版本: 1.14.0, 1.13.1, 1.12.4
报告人: JasonLee
优先级: 重要
标签: documentation

When I studied the memory model of TaskManager, I found that there is a problem 
in the official document, which is the description of 
taskmanager.memory.task.heap.size is incorrect.
According to the official memory model, I think the correct description should 
be that task Heap Memory size for TaskExecutors. This is the size of JVM heap 
memory reserved for tasks. If not specified, it will be derived as Total Flink 
Memory minus Framework Heap Memory, Framework Off-Heap Heap Memory, Task 
Off-Heap Memory, Managed Memory and Network Memory.
However, in the official document, the Framework Off-Heap Heap Memory should be 
subtracted.



--
这条信息是由Atlassian Jira发送的
(v8.3.4#803005)


> The description of taskmanager.memory.task.heap.size in the official document 
> is incorrect
> ------------------------------------------------------------------------------------------
>
>                 Key: FLINK-22963
>                 URL: https://issues.apache.org/jira/browse/FLINK-22963
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.14.0, 1.13.1, 1.12.4
>            Reporter: JasonLee
>            Priority: Major
>              Labels: documentation, starter
>
> When I studied the memory model of TaskManager, I found that there is a 
> problem in the official document, which is the description of 
> taskmanager.memory.task.heap.size is incorrect.
> According to the official memory model, I think the correct description 
> should be that task Heap Memory size for TaskExecutors. This is the size of 
> JVM heap memory reserved for tasks. If not specified, it will be derived as 
> Total Flink Memory minus Framework Heap Memory, Framework Off-Heap Heap 
> Memory, Task Off-Heap Memory, Managed Memory and Network Memory.
> However, in the official document, the Framework Off-Heap Heap Memory should 
> be subtracted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to