[
https://issues.apache.org/jira/browse/FLINK-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295608#comment-15295608
]
ASF GitHub Bot commented on FLINK-3728:
---------------------------------------
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/2018
[FLINK-3728] [tableAPI] Improve error message and documentation for
unsupported SQL features.
This PR
1. extends the Table API / SQL documentation and lists known limitations.
2. improves the error message in case Calcite cannot fails to optimize the
program because it includes unsupported features.
- [X] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [X] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [X] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink tableSupportedFeatures
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2018.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2018
----
commit bd8c4c94a220d57bfcfd3b4a6a52334f1e1940bd
Author: Fabian Hueske <fhue...@apache.org>
Date: 2016-05-22T10:43:19Z
[FLINK-3728] [tableAPI] Improve error message and documentation for
unsupported SQL features.
----
> Throw meaningful exceptions for unsupported SQL features
> --------------------------------------------------------
>
> Key: FLINK-3728
> URL: https://issues.apache.org/jira/browse/FLINK-3728
> Project: Flink
> Issue Type: Bug
> Components: Table API
> Affects Versions: 1.1.0
> Reporter: Vasia Kalavri
> Assignee: Fabian Hueske
>
> We must explicitly exclude unsupported SQL features such as Grouping Sets
> from being translated to Flink programs.
> Otherwise, the resulting program will compute invalid results.
> For that we must restrict the Calcite rules that translate Logical
> {{RelNodes}} into {{DataSetRel}} or {{DataStreamRel}} nodes.
> We may only translate to {{DataSetRel}} or {{DataStreamRel}} nodes if these
> support the semantics of the {{RelNode}}.
> Not translating a {{RelNode}} will yield a Calcite {{CannotPlanException}}
> that we should catch and enrich with a meaningful error message.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
