[ https://issues.apache.org/jira/browse/FLINK-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flink Jira Bot updated FLINK-12182: ----------------------------------- Labels: auto-deprioritized-major auto-unassigned (was: auto-unassigned stale-major) Priority: Minor (was: Major) This issue was labeled "stale-major" 7 ago and has not received any updates so it is being deprioritized. If this ticket is actually Major, please raise the priority and ask a committer to assign you the issue or revive the public discussion. > AggregateProjectMergeRule can not handle LogicalWindowAggregate > --------------------------------------------------------------- > > Key: FLINK-12182 > URL: https://issues.apache.org/jira/browse/FLINK-12182 > Project: Flink > Issue Type: Bug > Components: Table SQL / API > Reporter: Hequn Cheng > Priority: Minor > Labels: auto-deprioritized-major, auto-unassigned > > Currently, we add the AggregateProjectMergeRule.INSTANCE in logical rule sets > and use it to remove project for aggregates. However, there are some bugs > when this rule be applied for the LogicalWindowAggregate. > When the project was removed, the input field names are changed, so the rule > has to update all fields in the Aggregate, while the field name in > LogicalWindow in LogicalWindowAggregate has not taken into consideration in > AggregateProjectMergeRule, as it is a rule in Calcite. > This problem also lies in other Aggregate rules such as > FilterAggregateTransposeRule and AggregateProjectPullUpConstantsRule, etc. > As a quick fix, I think we can change > {code:java} > AggregateProjectMergeRule.INSTANCE, > {code} > to > {code:java} > new AggregateProjectMergeRule( > classOf[LogicalAggregate], classOf[Project], > RelFactories.LOGICAL_BUILDER), > {code} > Of course, we need a complete solution for the LogicalWindowAggregate(use > LogicalAggregate to express LogicalWindowAggregate), but not in this jira. > Any suggestions are welcomed! -- This message was sent by Atlassian Jira (v8.3.4#803005)