[ 
https://issues.apache.org/jira/browse/FLINK-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297815#comment-15297815
 ] 

ASF GitHub Bot commented on FLINK-3941:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2025#discussion_r64338444
  
    --- Diff: 
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/table/UnionITCase.java
 ---
    @@ -43,7 +43,7 @@ public UnionITCase(TestExecutionMode mode) {
        }
     
        @Test
    -   public void testUnion() throws Exception {
    +   public void testUnionAll() throws Exception {
    --- End diff --
    
    Actually, I would completely remove the whole Java `UnionITCase.java` file. 
It tests exactly the same methods as the Scala tests (no expression parsing 
involved). 


> Add support for UNION (with duplicate elimination)
> --------------------------------------------------
>
>                 Key: FLINK-3941
>                 URL: https://issues.apache.org/jira/browse/FLINK-3941
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API
>    Affects Versions: 1.1.0
>            Reporter: Fabian Hueske
>            Assignee: Yijie Shen
>            Priority: Minor
>
> Currently, only UNION ALL is supported by Table API and SQL.
> UNION (with duplicate elimination) can be supported by applying a 
> {{DataSet.distinct()}} after the union on all fields. This issue includes:
> - Extending {{DataSetUnion}}
> - Relaxing {{DataSetUnionRule}} to translated non-all unions.
> - Extend the Table API with union() method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to