Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2025#discussion_r64339091
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/table/UnionITCase.scala
---
@@ -54,7 +54,22 @@ class UnionITCase(
}
@Test
- def testTernaryUnion(): Unit = {
+ def testUnion(): Unit = {
--- End diff --
There were some concerns about the build time of the `flink-table` module
lately. In the past, we added quite a few integration tests without thinking
about the added coverage vs. build time trade-off.
I would propose to replace the `testUnionWithFilter()` and
`testUnionWithJoin()` tests with your new methods because these methods do not
add to test coverage, IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
