jinxing64 opened a new pull request #16193: URL: https://github.com/apache/flink/pull/16193
## What is the purpose of the change In current `PartitionRequestClientFactory#createPartitionRequestClient`, `ChannelFuture#await()` is invoked, thus to build a connection to remote synchronously. But with the doc of `io.netty.util.concurrent.Future`[1] and its implementation `io.netty.channel.DefaultChannelPromise`[2], `ChannelFuture#await()` never throws when completed with failure. I guess what Flink needs is `ChannelFuture#sync()`. [1] https://netty.io/4.1/api/io/netty/util/concurrent/class-use/Future.html [2] https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/DefaultChannelPromise.java https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/concurrent/DefaultPromise.java ## Brief change log - Replace `ChannelFuture#await` with `ChannelFuture#sync` in `PartitionRequestClientFactory#connect` - Removed some unused codes in `PartitionRequestClientFactoryTest` ## Verifying this change Added test `PartitionRequestClientFactoryTest#testThrowsWhenNetworkFailure` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
