Zakelly commented on a change in pull request #16153:
URL: https://github.com/apache/flink/pull/16153#discussion_r654332187
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java
##########
@@ -102,13 +102,15 @@
/** Whether to enable state change log. */
@Documentation.Section(value =
Documentation.Sections.COMMON_STATE_BACKENDS)
- @Documentation.ExcludeFromDocumentation("Hidden for now")
public static final ConfigOption<Boolean> ENABLE_STATE_CHANGE_LOG =
ConfigOptions.key("state.backend.changelog.enabled")
.booleanType()
- .defaultValue(false)
+ .noDefaultValue()
Review comment:
Yes, the default value here is false, but the return value of
```StreamExecutionEnvironment::isChangelogStateBackendEnabled``` is a
```TernaryBoolean```, which may bring some confusion. The ```TernaryBoolean```
is essential cause table planner uses the value to create StreamGraphGenerator
(see
[here](https://github.com/apache/flink/pull/16153/commits/2c78381d58d1e7e3ee3edd06afb03e7e6eb1f177#diff-c2ed4f07637221036620a06234633cbed96eedf4f29297fd3d766b3e1e751cbaR48)).
@rkhachatryan and @curcur would you please to take a look?
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java
##########
@@ -102,13 +102,15 @@
/** Whether to enable state change log. */
@Documentation.Section(value =
Documentation.Sections.COMMON_STATE_BACKENDS)
- @Documentation.ExcludeFromDocumentation("Hidden for now")
public static final ConfigOption<Boolean> ENABLE_STATE_CHANGE_LOG =
ConfigOptions.key("state.backend.changelog.enabled")
.booleanType()
- .defaultValue(false)
+ .noDefaultValue()
Review comment:
Yes, I set the default value here to false, but the return value of
```StreamExecutionEnvironment::isChangelogStateBackendEnabled``` is a
```TernaryBoolean```, which may bring some confusion. The ```TernaryBoolean```
is essential cause table planner uses the value to create StreamGraphGenerator
(see
[here](https://github.com/apache/flink/pull/16153/commits/2c78381d58d1e7e3ee3edd06afb03e7e6eb1f177#diff-c2ed4f07637221036620a06234633cbed96eedf4f29297fd3d766b3e1e751cbaR48)).
@rkhachatryan and @curcur would you please to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
