iemre commented on a change in pull request #16187:
URL: https://github.com/apache/flink/pull/16187#discussion_r654254123
##########
File path: flink-connectors/flink-sql-connector-kinesis/pom.xml
##########
@@ -35,17 +35,6 @@ under the License.
<packaging>jar</packaging>
- <dependencyManagement>
- <dependencies>
- <dependency>
- <!-- Bumped for security purposes to a common
version in the Hadoop ecosystem -->
- <groupId>com.google.guava</groupId>
- <artifactId>guava</artifactId>
- <version>27.0-jre</version>
- </dependency>
- </dependencies>
- </dependencyManagement>
Review comment:
the `flink-connector-kinesis` dependency (which is a part of the
flink-connectors project) further below already declares Guava in its
`pom.xml`. So we can get Guava transitively through `flink-connector-kinesis`
and manage the Guava dependency in `flink-connector-kinesis/pom.xml` in a "one
source of truth" way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
