rkhachatryan commented on a change in pull request #15420: URL: https://github.com/apache/flink/pull/15420#discussion_r656139960
########## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/restore/KvStateStateChangeApplier.java ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.state.changelog.restore; + +import org.apache.flink.core.memory.DataInputView; +import org.apache.flink.runtime.state.KeyGroupRangeAssignment; +import org.apache.flink.runtime.state.heap.InternalKeyContext; +import org.apache.flink.runtime.state.internal.InternalKvState; +import org.apache.flink.state.changelog.StateChangeOperation; + +abstract class KvStateStateChangeApplier<K, N> implements StateChangeApplier { + private final InternalKeyContext<K> keyContext; + + protected abstract InternalKvState<K, N, ?> getState(); + + protected KvStateStateChangeApplier(InternalKeyContext<K> keyContext) { + this.keyContext = keyContext; + } + + @Override + public void apply(StateChangeOperation operation, DataInputView in) throws Exception { + K key = getState().getKeySerializer().deserialize(in); + keyContext.setCurrentKey(key); Review comment: Good question. This can trigger heap incremental TTL cleanup, if enabled. That shouldn't have correctness but may have performance implications. I think this can be addressed separately though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
