rkhachatryan commented on a change in pull request #15420:
URL: https://github.com/apache/flink/pull/15420#discussion_r657791947
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/AbstractStateChangeLogger.java
##########
@@ -151,10 +160,11 @@ private void logMetaIfNeeded() throws IOException {
throws IOException {
return serializeRaw(
wrapper -> {
- wrapper.writeByte(op.code);
+ wrapper.writeByte(op.getCode());
// todo: optimize in FLINK-22944 by either writing short
code or grouping and
// writing once (same for key, ns)
wrapper.writeUTF(metaInfo.getName());
+ wrapper.writeByte(stateType.getCode());
Review comment:
Yes, different state types are written to the same log. So they need to
be differentiated on recovery (each change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
