Github user fpompermaier commented on the pull request:
https://github.com/apache/flink/pull/2007#issuecomment-221880071
I don't understand :(
Assuming that `reset` could be renamed as `resetErrorStateAndParse`, the
other 2 suggestions cannot be applied to my current implementation: if I want
to rename `parseFieldImpl` to `parseField` I should overload somehow the method
otherwise that's not possible because there's already an abstract method called
parseField with the same sign..
Wrt leaving the responsibility to reset the state of the parsers to the
classes calling the parseField is quite dangerous IMHo (as you said in
"GenericCsvInputCormat would call the resetErrorStateAndParse").
Am I misunderstanding something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
