XComp commented on pull request #16286: URL: https://github.com/apache/flink/pull/16286#issuecomment-869949832
> @XComp , thanks for your efforts to update the pull request again me. I have reviewed the changes of the refactors. I have confusion about why not validate whether to retrever job graph in tests, which originally validate through retrieveJobGraph. Thanks for your review. I addressed two of the changes and rebased the branch. About your questions with not using the retriever job graph. Building the `PackagedProgram` will trigger the class loading internally. This is problematic for testing the system classpath functionality. I tried to use legacy test code as much as possible. New tests, in contrast, avoid loading the class from classpath but rather check whether the correct class is selected. That's why the test implementation focuses on the `EntryClassInformationProvider`. It's more of a unit test rather than a test testing multiple classes interacting with each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
