XComp commented on a change in pull request #16286: URL: https://github.com/apache/flink/pull/16286#discussion_r661754312
########## File path: flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgramRetrieverImpl.java ########## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.client.program; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.client.deployment.application.EntryClassInformationProvider; +import org.apache.flink.client.deployment.application.FromClasspathEntryClassInformationProvider; +import org.apache.flink.client.deployment.application.FromJarEntryClassInformationProvider; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.util.FileUtils; +import org.apache.flink.util.FlinkException; +import org.apache.flink.util.Preconditions; +import org.apache.flink.util.function.FunctionUtils; + +import javax.annotation.Nullable; + +import java.io.File; +import java.io.IOException; +import java.net.URL; +import java.nio.file.Path; +import java.util.Collections; +import java.util.List; +import java.util.stream.Collectors; + +/** {@code PackageProgramRetrieverImpl} implements {@link PackagedProgramRetriever}. */ +public class PackagedProgramRetrieverImpl implements PackagedProgramRetriever { + + private final EntryClassInformationProvider entryClassInformationProvider; + private final String[] programArguments; + private final List<URL> userClasspath; + private final Configuration configuration; + + /** + * Creates a {@code PackageProgramRetrieverImpl} with the given parameters. + * + * @param userLibDir The user library directory that is used for generating the user classpath + * if specified. The system classpath is used if not specified. + * @param jobClassName The job class that will be used if specified. The classpath is used to + * detect any main class if not specified. + * @param programArgs The program arguments. + * @param configuration The Flink configuration for the given job. + * @return The {@code PackageProgramRetrieverImpl} that can be used to create a {@link + * PackagedProgram} instance. + * @throws FlinkException If something goes wrong during instantiation. + */ + public static PackagedProgramRetrieverImpl create( + @Nullable File userLibDir, + @Nullable String jobClassName, + String[] programArgs, + Configuration configuration) + throws FlinkException { + return create(userLibDir, null, jobClassName, programArgs, configuration); + } + + /** + * Creates a {@code PackageProgramRetrieverImpl} with the given parameters. + * + * @param userLibDir The user library directory that is used for generating the user classpath + * if specified. The system classpath is used if not specified. + * @param jarFile The jar archive used expecting to have the job class included. + * @param jobClassName The job class that will be used if specified. The classpath is used to + * detect any main class if not specified. + * @param programArgs The program arguments. + * @param configuration The Flink configuration for the given job. + * @return The {@code PackageProgramRetrieverImpl} that can be used to create a {@link + * PackagedProgram} instance. + * @throws FlinkException If something goes wrong during instantiation. + */ + public static PackagedProgramRetrieverImpl create( + @Nullable File userLibDir, + @Nullable File jarFile, Review comment: I'm not 100% sure whether I understand correctly. You're referring to `jarFile`? My goal was to have the `createEntryClassInformationProvider` method contain all the different code paths to select the right `EntryClassInformationProvider`. That enabled us to test this method specifically and be as close as possible to the original code. Making one of the fields `@Nonnull` would have meant to move some if condition out of this method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
