XComp commented on a change in pull request #16286:
URL: https://github.com/apache/flink/pull/16286#discussion_r662079061
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/program/PackagedProgramRetrieverImplTest.java
##########
@@ -215,20 +215,6 @@ public void testCreateWithUserLibDir() throws
FlinkException {
is(classpathProvider.getJobClassName()));
}
- @Test
- public void testCreateWithoutUserLibDir() throws IOException,
FlinkException {
Review comment:
Not setting the user classpath makes the code fallback to the system
classpath. We're not able to modify the system classpath after JVM is started
already. Modifying `java.class.path` doesn't help here. The default system
classpath contains multiple classes with main methods. That's why, the test
would fail. The code path is, instead, covered by
PackagedProgramRetrieverImplTest.testDeriveEntryClassInformationFromSystemClasspathExtractingTheJobClassFromThere`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
