[
https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304422#comment-15304422
]
ASF GitHub Bot commented on FLINK-3129:
---------------------------------------
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-222208597
no my concern wasn't even remotely addressed.
The public static String CONFIG_KEY was removed in commit
5a7f4e3395bfb06da496584be88501c328f6ac1d, violating the interface stability.
In commit 6c079360c60f47a336eda2f8936a6bddfb948058 you add CONFIG_KEY in
the ExecutionConfig, while the subsequent commit
b0acd97935cd21843bac3b9b5afa3662b52bb95d removes it again.
so now the public static key is still removed which shouldn't be the case,
no?
> Add tooling to ensure interface stability
> -----------------------------------------
>
> Key: FLINK-3129
> URL: https://issues.apache.org/jira/browse/FLINK-3129
> Project: Flink
> Issue Type: Sub-task
> Components: Build System
> Reporter: Robert Metzger
> Assignee: Robert Metzger
> Fix For: 1.1.0
>
>
> I would like to use this maven plugin: https://github.com/siom79/japicmp to
> automatically ensure interface stability across minor releases.
> Ideally we have the plugin in place after Flink 1.0 is out, so that maven
> builds break if a breaking change has been made.
> The plugin already supports downloading a reference release, checking the
> build and breaking it.
> Not yet supported are class/method inclusions based on annotations, but I've
> opened a pull request for adding it.
> There are also issues with the resolution of the dependency with the
> annotations, but I'm working on resolving those issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
