tsreaper opened a new pull request #16435:
URL: https://github.com/apache/flink/pull/16435


   (This commit is cherry-picked from #16406)
   
   ## What is the purpose of the change
   
   Currently code generation of unary plus and minus will not cast the result 
term to its desired type. This will cause compile error if the desired type is 
`short` or `byte`. Consider the following java code.
   
   ```java
   short a = 1;
   short b = -a;
   ```
   
   This code will not compile as `-a` is of `int` type.
   
   This PR fixes this issue by casting the result term.
   
   ## Brief change log
   
    - Fix compile error in code generation of unary plus and minus
   
   ## Verifying this change
   
   This change added tests and can be verified by running the added tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to