[
https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15308516#comment-15308516
]
ASF GitHub Bot commented on FLINK-3763:
---------------------------------------
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2054#discussion_r65253162
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -35,24 +36,28 @@
private static final Logger LOG =
LoggerFactory.getLogger(RMQSink.class);
private String QUEUE_NAME;
- private String HOST_NAME;
+ private RMQConnectionConfig rmqConnectionConfig;
private transient ConnectionFactory factory;
private transient Connection connection;
private transient Channel channel;
private SerializationSchema<IN> schema;
- public RMQSink(String HOST_NAME, String QUEUE_NAME,
SerializationSchema<IN> schema) {
- this.HOST_NAME = HOST_NAME;
+ /**
+ * @param rmqConnectionConfig The RabbiMQ connection configuration
{@link RMQConnectionConfig}.
+ * @param QUEUE_NAME The queue to publish messages to.
+ * @param schema A {@link SerializationSchema} for turning the Java
objects received into bytes
+ */
+ public RMQSink(RMQConnectionConfig rmqConnectionConfig, String
QUEUE_NAME, SerializationSchema<IN> schema) {
--- End diff --
Same here with the QUEUE_NAME
> RabbitMQ Source/Sink standardize connection parameters
> ------------------------------------------------------
>
> Key: FLINK-3763
> URL: https://issues.apache.org/jira/browse/FLINK-3763
> Project: Flink
> Issue Type: Improvement
> Components: Streaming Connectors
> Affects Versions: 1.0.1
> Reporter: Robert Batts
> Assignee: Subhankar Biswas
>
> The RabbitMQ source and sink should have the same capabilities in terms of
> establishing a connection, currently the sink is lacking connection
> parameters that are available on the source. Additionally, VirtualHost should
> be an offered parameter for multi-tenant RabbitMQ clusters (if not specified
> it goes to the vhost '/').
> Connection Parameters
> ===================
> - Host - Offered on both
> - Port - Source only
> - Virtual Host - Neither
> - User - Source only
> - Password - Source only
> Additionally, it might be worth offer the URI as a valid constructor because
> that would offer all 5 of the above parameters in a single String.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
