Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2054#discussion_r65253122
  
    --- Diff: 
flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
 ---
    @@ -35,24 +36,28 @@
        private static final Logger LOG = 
LoggerFactory.getLogger(RMQSink.class);
     
        private String QUEUE_NAME;
    --- End diff --
    
    I know its not part of the issue's scope, but could you rename this field 
to `queueName`. Otherwise, the class has a very poor style which makes it hard 
to read it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to