Thesharing commented on pull request #15148: URL: https://github.com/apache/flink/pull/15148#issuecomment-879237820
> What are these tests actually testing @zhuzhurk @Thesharing? It seems that they only call `SchedulerBase.startScheduling` and that's it. This seems not like a very specific test. We add this benchmark because we find that existing benchmarks cannot cover the entire procedure of scheduling, like `DefaultScheduler#allocateSlotsAndDeploy`, and etc. We cannot add benchmarks for each method, since it will make the benchmarks complicated and takes long time to run them all. Furthermore, if anyone insert a procedure, we cannot track on it. Thus, we think it's necessary to add a benchmark that covers the entire procedure. If anything related to scheduling changes, we can immediately know about it according to this end-to-end benchmark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
